-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Devfile plugin for provision Run Configurations #78
Conversation
Hello, could you make sure that omitting working directory will use PROJECT_SOURCE folder ( And of course it could be a following PR) |
Hi! If property In this case default working directory will be As for replacing environment variables. Each variable that is provided in So it depends how user configured the parameter |
no working directory in devfile, set workdir to PROJECT_SOURCE |
we can provide additional PR for this, after resolving eclipse-che/che#21079, because we haven't had this variable in environment yet |
it's there since devfile/devworkspace-operator#697 |
plugins/devfile-plugin/src/main/kotlin/che/incubator/devfile/DevfileConfigurable.kt
Outdated
Show resolved
Hide resolved
I have both:
in my Che instance. |
@vzhukovs create an issue for that. So, we won't forget fixing that in the next iteration. |
Signed-off-by: Vladyslav Zhukovskyi <vzhukovs@redhat.com>
Created the issue: eclipse-che/che#21100 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't test it on the Che dogfooding instance, as I get
@vzhukovs what instance have you used for testing?
I've also tried on RHPDS. The Dashboard logs:
|
Try to follow this steps:
|
The good news is that pre-pulling the UDI image really helped to avoid terminating the workspace start by timeout. 👍 Thanks for the advice! I was able to start a DevWorkspace from https://github.com/vzhukovs/che-21029. Also, I've tried the link provided the PR description - And I've got the same result. |
Prerequisites for appearing Run Configurations is finished project indexing. After that Run Configurations is become available. This is the limitation of IntelliJ IDEA. The factory link from the description should be updated as it should contain the plugin before removing the preference page. So it not actual, will update the description. The correct repository for testing is: https://github.com/vzhukovs/che-21029 This one was used to record the demo flow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job!
Current changes proposal provides plugin for Devfile support. Especially for provision commands from Devfile as Run Configuration in IntelliJ-based IDEs.
Plugin listens to Project open event and look for environment variable
DEVWORKSPACE_FLATTENED_DEVFILE
. Then, when Project is opened it takes content byDEVWORKSPACE_FLATTENED_DEVFILE
and parses exec commands:Then user is able to run command provided by Devfile from the IDE UI:
To check how it works with already created Devfiles it is enough to create the workspace from the following factory link:
or create the workspace from the following repository: https://github.com/vzhukovs/che-21029
fixes eclipse-che/che#21029
Signed-off-by: Vladyslav Zhukovskyi vzhukovs@redhat.com