fix(group): Make group cluster scoped #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 8a23b56.
We do not actually need to make the groups part of namespaces, they can be cluster scoped, this way any ApiCheck in any namespace can read it. It's a much better solution than specifying the namespace for each group. Tested locally, tests updated to not use a namespace for the group resource.
ianaya89
approved these changes
Jul 21, 2022
|
🎉 This PR is included in version 1.3.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We do not actually need to make the groups part of namespaces, they can
be cluster scoped, this way any ApiCheck in any namespace can read it.
It's a much better solution than specifying the namespace for each
group.
Tested locally, tests updated to not use a namespace for the group
resource.