Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(logging): fix log level #53

Merged
merged 1 commit into from
Dec 4, 2024
Merged

chore(logging): fix log level #53

merged 1 commit into from
Dec 4, 2024

Conversation

akosveres
Copy link
Collaborator

@sorccu
Copy link

sorccu commented Nov 15, 2024

For future reference, would it be possible for you to briefly describe the differences between the two loggers that seem to be used (logr and zap)?

And related to that, is it enough to be able to set zap's log level via the CLI option, but not have it affect logr's level at all?

@akosveres
Copy link
Collaborator Author

For future reference, would it be possible for you to briefly describe the differences between the two loggers that seem to be used (logr and zap)?

And related to that, is it enough to be able to set zap's log level via the CLI option, but not have it affect logr's level at all?

Here's an explanation from the operator-sdk, which we're using to setup the project, https://sdk.operatorframework.io/docs/building-operators/golang/references/logging/ - Does this help?

* Fix log levels across multiple log lines
* Add missing log lines
* Adjust log levels
* Update docs
* This addresses issue
  #50
Copy link

@sorccu sorccu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@akosveres akosveres merged commit d0d693e into main Dec 4, 2024
2 checks passed
@akosveres akosveres deleted the logging_levels branch December 4, 2024 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants