ci: update codecov-action from v3 to v4

[rst0git]

No description provided.

[github-actions]

Test Results

55 tests  ±0   55 ✅ ±0   1s ⏱️ ±0s
 1 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit 62d2ebe. ± Comparison against base commit b1f1c3b.

♻️ This comment has been updated with latest results.

[snprajwal]

@rst0git the coverage workflow on the main branch succeeds as of now without any problems: https://github.com/checkpoint-restore/checkpointctl/actions/runs/10009967467/job/27670052231

[rst0git]

the coverage workflow on the main branch succeeds as of now without any problems: https://github.com/checkpoint-restore/checkpointctl/actions/runs/10009967467/job/27670052231

@snprajwal The workflow is unable to access the upload token in pull requests (e.g., #141, #140)

##[debug]Evaluating: secrets.CODECOV_TOKEN
##[debug]Evaluating Index:
##[debug]..Evaluating secrets:
##[debug]..=> Object
##[debug]..Evaluating String:
##[debug]..=> 'CODECOV_TOKEN'
##[debug]=> null

[snprajwal]

Right, so it seems GitHub does not allow accessing secrets implicitly in workflows triggered on commits outside the upstream repo: https://docs.github.com/en/actions/security-guides/using-secrets-in-github-actions#using-secrets-in-a-workflow

Adding a with item with the secret should fix this for us? Scratch that, looks like GitHub just refuses to pass secrets to commits on a fork

[snprajwal]

Going by the docs, the pull_request trigger does not allow access to secrets, but the pull_request_target trigger does. Can we try this?

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.88%. Comparing base (ee4e4e3) to head (62d2ebe).
Report is 2 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #140      +/-   ##
==========================================
+ Coverage   78.73%   80.88%   +2.15%     
==========================================
  Files          11       11              
  Lines        1260      994     -266     
==========================================
- Hits          992      804     -188     
+ Misses        201      123      -78     
  Partials       67       67              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[rst0git]

@snprajwal It looks like tokenless uploading works with PRs:

• Can v4 still securely work with pull requests? codecov/codecov-action#1431 (comment)
• Codecov: remove token, turn off CI failure netobserv/network-observability-console-plugin#531

[snprajwal]

@rst0git by the way, reading the issue you linked, it looks like the token is required for PRs coming from the base repo + commits on the base repo itself, and forks can use the tokenless version. If that is indeed the case, we might require another check to decide if the token should be used or not (based on whether the trigger is push or pull_request)

[rst0git]

@snprajwal This problem seems to be fixed with codecov/codecov-action#1437.