-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve tests, code coverage, and Makefile targets #131
Conversation
The E2E test was previously testing encode, decode and explore commands. It now also tests the show and info commands on `inventory.img`. Signed-off-by: Prajwal S N <prajwalnadig21@gmail.com>
Generated files like protobuf bindings are not required to be checked for test coverage. This commit removes the coverage statistics for these files from `coverage.out` after merging coverage results. Signed-off-by: Prajwal S N <prajwalnadig21@gmail.com>
The Make targets in `test` would not fail upon errors due the block scope of the shell command. This issue has been fixed with a trap to kill the test process upon failure. Signed-off-by: Prajwal S N <prajwalnadig21@gmail.com>
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #131 +/- ##
===========================================
+ Coverage 22.74% 48.84% +26.10%
===========================================
Files 95 22 -73
Lines 15292 2381 -12911
===========================================
- Hits 3478 1163 -2315
+ Misses 11514 1059 -10455
+ Partials 300 159 -141 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
crit info
andcrit show
commands. The test has been extended to include these.PTAL @adrianreber @rst0git