Improve tests, code coverage, and Makefile targets #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The E2E test was previously testing encode, decode and explore commands. It now also tests the show and info commands on `inventory.img`. Signed-off-by: Prajwal S N <prajwalnadig21@gmail.com>
Generated files like protobuf bindings are not required to be checked for test coverage. This commit removes the coverage statistics for these files from `coverage.out` after merging coverage results. Signed-off-by: Prajwal S N <prajwalnadig21@gmail.com>
The Make targets in `test` would not fail upon errors due the block scope of the shell command. This issue has been fixed with a trap to kill the test process upon failure. Signed-off-by: Prajwal S N <prajwalnadig21@gmail.com>
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #131 +/- ##
===========================================
+ Coverage 22.74% 48.84% +26.10%
===========================================
Files 95 22 -73
Lines 15292 2381 -12911
===========================================
- Hits 3478 1163 -2315
+ Misses 11514 1059 -10455
+ Partials 300 159 -141 ☔ View full report in Codecov by Sentry. |
adrianreber
reviewed
May 12, 2023
rst0git
reviewed
May 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
crit infoandcrit showcommands. The test has been extended to include these.PTAL @adrianreber @rst0git