chore(crit): improve Makefile rule #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrianreber
approved these changes
Aug 1, 2023
Previously, the Makefile in `crit` would not rebuild the binary even if any of the related source files changed. This is now fixed by marking all Go files under the directory as prerequisites for the `bin/crit` recipe. Signed-off-by: Prajwal S N <prajwalnadig21@gmail.com>
rst0git
approved these changes
Aug 1, 2023
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #141 +/- ##
=======================================
Coverage 50.34% 50.34%
=======================================
Files 24 24
Lines 2590 2590
=======================================
Hits 1304 1304
Misses 1102 1102
Partials 184 184 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the Makefile in
critwould not rebuild the binary even if any of the related source files changed. This is now fixed by marking all Go files under the directory as prerequisites for thebin/critrecipe.