Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix lints from protogetter #153

Merged
merged 1 commit into from
Nov 1, 2023

Conversation

snprajwal
Copy link
Member

The new version of golangci-lint enables a new linter, which checks for direct access to protobuf fields. The offending instances have now been fixed.

The new version of golangci-lint enables a new linter, which checks for
direct access to protobuf fields. The offending instances have now been
fixed.

Signed-off-by: Prajwal S N <prajwalnadig21@gmail.com>
Copy link

codecov bot commented Nov 1, 2023

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (3835b6f) 50.50% compared to head (3a12cbd) 50.50%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #153   +/-   ##
=======================================
  Coverage   50.50%   50.50%           
=======================================
  Files          24       24           
  Lines        2865     2865           
=======================================
  Hits         1447     1447           
  Misses       1220     1220           
  Partials      198      198           
Files Coverage Δ
crit/explore.go 61.19% <100.00%> (ø)
crit/mempages.go 93.54% <100.00%> (ø)
main.go 56.89% <71.42%> (ø)
test/main.go 44.65% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rst0git rst0git merged commit 4c57022 into checkpoint-restore:master Nov 1, 2023
13 of 14 checks passed
@snprajwal snprajwal deleted the lint-fixes branch December 20, 2023 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants