chore: fix linting issues #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #162 +/- ##
=======================================
Coverage 50.50% 50.50%
=======================================
Files 24 24
Lines 2865 2865
=======================================
Hits 1447 1447
Misses 1220 1220
Partials 198 198 ☔ View full report in Codecov by Sentry. |
rst0git
reviewed
Mar 4, 2024
Add fixes for performance-related linting issues identified by the perfsprint linter introduced in golangci-lint v1.55.0. perfsprint is a linter for performance, aiming at usages of fmt.Sprintf which have faster alternatives in the standard library. This commit fixes linting issues reported by perfsprint, including: - Replacing instances of fmt.Sprint with faster alternatives like strconv.FormatUint and utilizing string addition in place of fmt.Sprintf. - Eliminating unnecessary use of fmt.Errorf by replacing it with the more concise errors.New. Signed-off-by: Kouame Behouba Manasse <behouba@gmail.com>
rst0git
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes linting issues reported by the latest version of
golangci-lint.