Add functions which are used in Podman, CRI-O and containerd #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #165 +/- ##
==========================================
- Coverage 50.50% 50.37% -0.13%
==========================================
Files 24 25 +1
Lines 2865 2908 +43
==========================================
+ Hits 1447 1465 +18
- Misses 1220 1238 +18
- Partials 198 205 +7 ☔ View full report in Codecov by Sentry. |
adrianreber
force-pushed
the
2024-03-12-common
branch
2 times, most recently
from
409c235
to
c9e3356
Compare
|
@adrianreber It is common to use import aliases in Go. For example, the alias import criu "github.com/checkpoint-restore/go-criu/v6/rpc" |
snprajwal
reviewed
Mar 12, 2024
Right, but the question is, if we come with a good name, then maybe the alias would not be necessary. |
adrianreber
force-pushed
the
2024-03-12-common
branch
from
c9e3356
to
115d2c1
Compare
Convenience functions to check if CRIU is available and at least a certain version are now used in containerd, CRI-O and Podman. This change moves those functions to go-criu. Signed-off-by: Adrian Reber <areber@redhat.com>
adrianreber
force-pushed
the
2024-03-12-common
branch
from
115d2c1
to
6908ab4
Compare
7 tasks
|
The missing test coverage seems to mainly in the test code. Not sure it makes sense to track test coverage in the actual test case 😉 |
snprajwal
approved these changes
Mar 14, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convenience functions to check if CRIU is available and at least a certain version are now used in containerd, CRI-O and Podman. This change moves those functions to go-criu.
I am not entirely sure about the naming and the location. If this used somewhere else it would be:
Which results in
utils, which is a very generic name. Maybe changing the directory name tocrutilswould be better?Not sure. Any ideas about naming to make it easy to include and understand where it is coming from?