Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(coverage): ignore test files #166

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

snprajwal
Copy link
Member

Codecov ignores unit tests by default, but does not recognise the test directory for integration tests. Tests are written to generate coverage, so it does not make sense to check the coverage of the tests themselves.

Codecov ignores unit tests by default, but does not recognise the `test`
directory for integration tests. Tests are written to generate coverage,
so it does not make sense to check the coverage of the tests themselves.

Signed-off-by: Prajwal S N <prajwalnadig21@gmail.com>
Copy link

codecov bot commented Mar 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.16%. Comparing base (5d0d8f1) to head (e0fcdcf).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #166      +/-   ##
==========================================
- Coverage   50.50%   49.16%   -1.35%     
==========================================
  Files          24       21       -3     
  Lines        2865     2337     -528     
==========================================
- Hits         1447     1149     -298     
+ Misses       1220     1054     -166     
+ Partials      198      134      -64     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@snprajwal snprajwal requested a review from rst0git March 14, 2024 10:39
Copy link
Member

@adrianreber adrianreber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. Thanks!

@rst0git rst0git merged commit 55534ec into checkpoint-restore:master Mar 14, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants