test/make: drop golang version check #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A check for the version of Golang was introduced with [1] because our test coverage requires Go version 1.20 or newer. Since we increased the minimum version to 1.20 [2], this check is no longer necessary. [1] checkpoint-restore@740974d [2] checkpoint-restore@9453d23 Signed-off-by: Radostin Stoyanov <rstoyanov@fedoraproject.org>
|
Currently we use 1.20 to run the coverage check in the GitHub Actions definition. Maybe we should also move that to 1.22. What do you think? |
adrianreber
approved these changes
Jul 16, 2024
|
|
Hmm, maybe the free plan does not exist anymore or is limited. Not sure. |
|
It might be good to make this change so that we're aware of coverage failures going forward |
rst0git
force-pushed
the
test-clean-up
branch
2 times, most recently
from
fd41758
to
0b2394d
Compare
rst0git
force-pushed
the
test-clean-up
branch
5 times, most recently
from
74d03f0
to
93a4db7
Compare
|
Seems to work again. No comment from codecov in the PR but maybe because the coverage did not change. |
rst0git
force-pushed
the
test-clean-up
branch
2 times, most recently
from
9b8a1cd
to
346f42f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #183 +/- ##
==========================================
+ Coverage 49.38% 51.20% +1.82%
==========================================
Files 22 22
Lines 2359 1949 -410
==========================================
- Hits 1165 998 -167
+ Misses 1058 815 -243
Partials 136 136 ☔ View full report in Codecov by Sentry. |
rst0git
force-pushed
the
test-clean-up
branch
5 times, most recently
from
f4bda7b
to
ea88d5a
Compare
Uploading code coverage currently fails with the following error: Rate limit reached. Please upload with the Codecov repository upload token to resolve issue. This patch replaces the codecov Makefile target, that was used to upload the coverage files, with a GitHub CI workflow [1]. This change allows us to specify a Codecov token [2] to authorize report uploads. In addition, this patch updates the version of Go used for coverage to 1.22 and configures the CI build to fail if Codecov encounters an error during upload. [1] https://github.com/codecov/codecov-action [2] https://docs.codecov.com/docs/github-2-getting-a-codecov-account-and-uploading-coverage Signed-off-by: Radostin Stoyanov <rstoyanov@fedoraproject.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A check for the version of Golang was introduced with 740974d because our test coverage requires Go version 1.20 or newer. Since we increased the minimum version to 1.20 (9453d23), this check is no longer necessary.
This pull request also fixes a problem in the CI with uploading the code coverage report to Codecov.