Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

textNode not passed into .filter method #1867

Closed
jeroentvb opened this issue May 13, 2021 · 2 comments · Fixed by #1870 · 4 remaining pull requests
Closed

textNode not passed into .filter method #1867

jeroentvb opened this issue May 13, 2021 · 2 comments · Fixed by #1870 · 4 remaining pull requests

Comments

@jeroentvb
Copy link

jeroentvb commented May 13, 2021 •
edited
Loading

The .filter(function) method only gets DOM elements passed in, while .each(function) gets all DOM nodes, including text nodes. This used to work in RC-5, but doesn't in RC-9. And as far as I could tell, this isn't expected behaviour, because I wasn't able to find info indicating that it is in the jQuery docs.

Consider the following html snippet:

<body>
    <div style="color: black;">Hello</div>
    world
    <small>!</small>
</body>

If I were to select the body and .filter its contents, I won't get the world text node in my filter loop. Whereas I will get the world text node in my loop if I use .each on the contents of the body.

I've created a repo demonstrating my findings.

Edit: just checked, it also used to work with RC-6. That means it stopped working with the RC-9 release.
fb55 added a commit that referenced this issue May 15, 2021
@fb55
fix(traversing): Make filter work on all collections
20d61aa 
Fixes #1867
@fb55 fb55 mentioned this issue May 15, 2021
Merged
@fb55
Copy link
Member

fb55 commented May 15, 2021

Thanks for reporting! I've opened #1870 with a fix.

@sehrgut
Copy link

sehrgut commented May 17, 2021

I commented on #1870 as well, but just for visibility: this should also iterate over comment nodes, which that commit still appears not to do.

fb55 added a commit that referenced this issue May 17, 2021
@fb55
fix(traversing): Make filter work on all collections (#1870)
fb8d31e 
Fixes #1867
@Omrisnyk Omrisnyk mentioned this issue Aug 11, 2024
Open
@bodrick bodrick mentioned this issue Aug 30, 2024
Open
@hikaruright hikaruright mentioned this issue Aug 30, 2024
Open
@drakulavich drakulavich mentioned this issue Aug 31, 2024
Open
@snooker4real snooker4real mentioned this issue Aug 31, 2024
Open
@0xbaha 0xbaha mentioned this issue Aug 31, 2024
Open
@Peter-McKinney Peter-McKinney mentioned this issue Aug 31, 2024
Open
@YoshiWalsh YoshiWalsh mentioned this issue Aug 31, 2024
Open
This was referenced Aug 31, 2024
Open
Open
Open
@paul-shuvo paul-shuvo mentioned this issue Aug 31, 2024
Open
This was referenced Sep 1, 2024
Open
Open
Open
Open
Open
Open
@0xbaha 0xbaha mentioned this issue Sep 8, 2024
Open
@YoshiWalsh YoshiWalsh mentioned this issue Sep 8, 2024
Open
This was referenced Sep 8, 2024
Open
Open
Open
Open
@AlbertoCime14 AlbertoCime14 mentioned this issue Sep 11, 2024
Open
@rizkimaung rizkimaung mentioned this issue Sep 11, 2024
Open
This was referenced Sep 12, 2024
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Sep 19, 2024
Open
Open
Open
@0xbaha 0xbaha mentioned this issue Sep 24, 2024
Open
@brandonyee333 brandonyee333 mentioned this issue Sep 24, 2024
Open
@InfiniteLove2020 InfiniteLove2020 mentioned this issue Oct 3, 2024
Open
@YoshiWalsh YoshiWalsh mentioned this issue Oct 5, 2024
Open
@0xbaha 0xbaha mentioned this issue Nov 1, 2024
Open
@YoshiWalsh YoshiWalsh mentioned this issue Nov 1, 2024
Open
@mihaibuzgau mihaibuzgau mentioned this issue Nov 1, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(traversing): Make filter work on all collections cheeriojs/cheerio
[Snyk] Security upgrade cheerio from 1.0.0-rc.2 to 1.0.0 Omrisnyk/npm-lockfiles
[Snyk] Upgrade cheerio from 1.0.0-rc.9 to 1.0.0 bodrick/vscode-plugins
[Snyk] Upgrade cheerio from 1.0.0-rc.10 to 1.0.0 hikaruright/markdown-hosting
[Snyk] Upgrade cheerio from 1.0.0-rc.10 to 1.0.0 drakulavich/frontend-testing-react-project-lvl1
[Snyk] Upgrade cheerio from 1.0.0-rc.10 to 1.0.0 snooker4real/myWebscraper
[Snyk] Upgrade cheerio from 1.0.0-rc.3 to 1.0.0 0xFORK/youtube-scrape
[Snyk] Upgrade cheerio from 1.0.0-rc.10 to 1.0.0 Peter-McKinney/mobile-parade-scraper
[Snyk] Upgrade cheerio from 1.0.0-rc.2 to 1.0.0 YoshiWalsh/gatsby-plugin-excerpts
[Snyk] Upgrade cheerio from 1.0.0-rc.3 to 1.0.0 WontonSam/cachimanexpress.js-Design-Patterns-Third-Edition
3 participants
@fb55 @sehrgut @jeroentvb