refactor(utils): Simplify quickExpr
#1716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now allows a `#` before the string. BREAKING: Now requires a letter directly after the `<`. Both parsers would have parsed this as text before. Reivival of #1699 Co-Authored-By: 5saviahv <49443574+5saviahv@users.noreply.github.com>
|
I see whats your aim is, and since it acts only for testing, it should be fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now allows a
#before the string.BREAKING: Now requires a letter directly after the
<. Both parsers would have parsed this as text before.@5saviahv #1699 was a great find, thanks for opening it! I wasn't sure about the actual implementation, here is my take; with it, we still allow text around the actual string, but ban things that definitely aren't tags (see breaking).