Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Have load export a function #1869

Merged
merged 11 commits into from
May 17, 2021
Merged

refactor: Have load export a function #1869

merged 11 commits into from
May 17, 2021

Conversation

fb55
Copy link
Member

@fb55 fb55 commented May 14, 2021 •
edited
Loading

This removes quite a few currently necessary hacks.

BREAKING CHANGES

Low potential for breakages:

  • Removed the internal _originalRoot property. Some methods, such as appendTo, can now have their roots overwritten by passing the root property to CheerioAPI.
  • The default export now has a surrounding Document, without any contents.

fb55 and others added 11 commits May 7, 2021 16:58
@fb55
fix: Make _root a full Cheerio instance
a793046
@fb55
Move toArray to traversing
f58c14d 
No need to have this in the main class
@fb55
Stop CheerioAPI from extending Cheerio statics
e590c54
@fb55
Remove _originalRoot
882f11e 
We are calling the constructor, which will always retain the original root.
@fb55
Stop exporting Cheerio base class
36a265c 
We maintain compatibility for now by exporting a sensible default.
@fb55
Have load export a function instead of the constructor
bb8b014 
Separates Cheerio and CheerioAPI as different concepts.

We no longer have to fight the type system to allow us to call the constructor without `new`.
@fb55
Move CheerioAPI definition to load.ts
ff01152
@fb55
Simplify some things
3a3f3f5
@fb55
Improve docs for CheerioAPI
dddd380
@fb55
Disallow passing null to _make
043fd85
@fb55 @5saviahv
Add test cases from #1706
5a9281b 
Co-Authored-By: 5saviahv <49443574+5saviahv@users.noreply.github.com>
@fb55 fb55 changed the title Have load export a function instead of the constructor refactor: Have load export a function May 17, 2021
@fb55 fb55 merged commit c370f4e into main May 17, 2021
@fb55 fb55 deleted the feat/fn branch May 17, 2021 12:31
@Omrisnyk Omrisnyk mentioned this pull request Aug 11, 2024
Open
@bodrick bodrick mentioned this pull request Aug 30, 2024
Open
@hikaruright hikaruright mentioned this pull request Aug 30, 2024
Open
@drakulavich drakulavich mentioned this pull request Aug 31, 2024
Open
@snooker4real snooker4real mentioned this pull request Aug 31, 2024
Open
@0xbaha 0xbaha mentioned this pull request Aug 31, 2024
Open
@Peter-McKinney Peter-McKinney mentioned this pull request Aug 31, 2024
Open
@YoshiWalsh YoshiWalsh mentioned this pull request Aug 31, 2024
Open
This was referenced Aug 31, 2024
Open
Open
Open
@paul-shuvo paul-shuvo mentioned this pull request Aug 31, 2024
Open
This was referenced Sep 1, 2024
Open
Open
Open
Open
@WontonSam WontonSam mentioned this pull request Sep 6, 2024
Open
@0xbaha 0xbaha mentioned this pull request Sep 8, 2024
Open
@YoshiWalsh YoshiWalsh mentioned this pull request Sep 8, 2024
Open
This was referenced Sep 8, 2024
Open
Open
Open
Open
@AlbertoCime14 AlbertoCime14 mentioned this pull request Sep 11, 2024
Open
This was referenced Sep 12, 2024
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Sep 19, 2024
Open
Open
Open
@0xbaha 0xbaha mentioned this pull request Sep 24, 2024