convert library resources to proper custom resources #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
library cookbooks are not a recommended cookbook pattern see: https://docs.chef.io/custom_resources_notes.html and issues like this which are directly related to trying to fight the resources DSL: chef-boneyard/httpd#97 Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
adds support back to chef 12.1 and allows the use of more recent chef-client features as well Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
|
bonus: added compat_resource cookbook dep |
some of these pessimistic constraints are doing more harm than good. Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
|
bonus bonus: try using a version of berkshelf than is less than a year old |
this isn't necessary at all in ruby >= 2.0 https://github.com/bbatsov/rubocop/blob/ec3123fc3454b080e1100e35480c6466d1240fff/lib/rubocop/cop/style/encoding.rb#L6-L15 Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
|
bonus bonus bonus: the Encoding cop is from the ruby-1.8/1.9 era so remove that |
|
Taking a look .. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
library cookbooks are not a recommended cookbook pattern
see:
https://docs.chef.io/custom_resources_notes.html
and issues like this which are directly related to trying to
fight the resources DSL:
chef-boneyard/httpd#97
Signed-off-by: Lamont Granquist lamont@scriptkiddie.org