Update fetcher for chef-server-visibility and add chef-server-compliance collector #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexpop
force-pushed
the
ap/attributes-refactor
branch
2 times, most recently
from
d8ef1de to
c0f9ef1
Compare
alexpop
changed the title
alexpop
force-pushed
the
ap/attributes-refactor
branch
2 times, most recently
from
d66b081 to
e69512d
Compare
alexpop
force-pushed
the
ap/attributes-refactor
branch
from
2b75224 to
0493808
Compare
|
Thanks Stephan, updated based on your feedback! |
alexpop
changed the title
…ance Signed-off-by: Alex Pop <apop@chef.io>
Signed-off-by: Alex Pop <apop@chef.io>
alexpop
force-pushed
the
ap/attributes-refactor
branch
from
0493808 to
74bd4a0
Compare
alexpop
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #158
The chef-server fetcher is also using a different fetching URL when reporter chef-server-visibility is used.
I was also thinking to introduce replace the current
chef-serverfetcher withchef-server-complianceand possibly add achef-server-automatereporter. In the interest of keeping this change small for now. I reverted the fetcher change.Attributes and README are not fully updated. Waiting for 👍 before doing that.