Removed the colon from the json-file filename #174
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 2, 2016 12:46
Signed-off-by: gbright <gary.bright@niu-solutions.com>
Signed-off-by: gbright <gary.bright@niu-solutions.com>
username-is-already-taken2
force-pushed
the
gbright/json_file_name
branch
from
72018f8 to
6488600
Compare
username-is-already-taken2
changed the title
|
Thank you @username-is-already-taken2 for reporting the issue. We went forward with #177 |
|
The main reason for #177 is that we generate the right filename instead of fixing the final string. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When writing the json-file to the filesystem the generated filename included a colon which caused an exception on windows systems as its an illegal char.
Issues Resolved
#173
Check List
Signed-off-by: gbright gary.bright@niu-solutions.com