Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed typo, Reporter::ChefServer does not exist. #236

Conversation

qubitrenegade
Copy link

Description

Line 241 calls Reporter::ChefServer however, this class doesn't exist.

I believe this should be Reporter::ChefServerCompliance based on the pattern of other reporters, that Reporter::ChefServerCompliance exists, and this change resolves the error on my Chef Server.

Bumped to version 4.0.2 as I submitted PREQ #235 which bumps the version to 4.0.1.

$ grep Reporter:: files/default/handler/audit_report.rb
          Reporter::ChefAutomate.new(opts).send_report(report)
            Reporter::ChefServerAutomate.new(opts).send_report(report)
            Reporter::ChefCompliance.new(opts).send_report(report)
            Reporter::ChefServer.new(opts).send_report(report)
          Reporter::JsonFile.new({ file: path }).send_report(report) 

Issues Resolved

#234

Check List

…rCompliance. Fixes chef-boneyard#234.  Bumped metadata to version 4.0.2

Signed-off-by: qubitrenegade <qubitrenegade@gmail.com>
@@ -5,7 +5,7 @@
license 'Apache-2.0'
description 'Allows for fetching and executing compliance profiles, and reporting its results'
long_description IO.read(File.join(File.dirname(__FILE__), 'README.md'))
version '4.0.0'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should not bump the versions with the PR

chris-rock
chris-rock previously approved these changes Jun 28, 2017
Copy link
Contributor

@chris-rock chris-rock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for that improvement @qubitrenegade

@chris-rock chris-rock dismissed their stale review June 28, 2017 13:22

version needs to be removed from metadata

Copy link
Contributor

@chris-rock chris-rock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to remove the version change

@chris-rock
Copy link
Contributor

Thank you @qubitrenegade I rebased and removed the version bump in #253

@chris-rock chris-rock closed this Jun 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants