Enable Inspec caching #297
Conversation
Signed-off-by: Jared Quick <jquick@chef.io>
| @@ -124,6 +129,7 @@ def get_opts(format, quiet, attributes) | |||
| 'format' => format, | |||
| 'output' => output, | |||
| 'logger' => Chef::Log, # Use chef-client log level for inspec run, | |||
| :backend_cache => node['audit']['inspec_backend_cache'], | |||
There was a problem hiding this comment.
Can we change this to use the new hash syntax instead of hash-rockets?
backend_cache: node['audit']['inspec_backend_cache']... the stuff above this apparently needs to be strings (but maybe it doesn't, we should probably check on that as some point), but if this key is expected to be a symbol, we should be consistent. 🙂
| @@ -38,6 +38,11 @@ def report | |||
| # load inspec, supermarket bundle and compliance bundle | |||
| load_needed_dependencies | |||
|
|
|||
| # check if we have a valid version for backend caching | |||
| if node['audit']['inspec_backend_cache'] && (Gem::Version.new(::Inspec::VERSION) < Gem::Version.new('1.47.0')) | |||
There was a problem hiding this comment.
We're now checking for a specific version constraint in two different places within this file... here, and:
I think we should move the MIN_INSPEC_VERSION one to be right above this, and out of the #call method. Or, possibly better yet, extract both to a validate_inspec_version! method and call it here in the #report method in place of this stanza. What do you think?
| @@ -38,6 +38,11 @@ def report | |||
| # load inspec, supermarket bundle and compliance bundle | |||
| load_needed_dependencies | |||
|
|
|||
| # check if we have a valid version for backend caching | |||
| if node['audit']['inspec_backend_cache'] && (Gem::Version.new(::Inspec::VERSION) < Gem::Version.new('1.47.0')) | |||
| Chef::Log.warn 'inspec_backend_cache requires Inspec version >= 1.47.0' | |||
There was a problem hiding this comment.
InSpec - capital S, please :)
| let(:mynode) { Chef::Node.new } | ||
|
|
||
| before :each do | ||
| mynode.default['audit']['inspec_backend_cache'] = true |
There was a problem hiding this comment.
Should we add a test that assures that opts[:backend_cache] gets set to false if the node attribute calls for it? I hate to only have a test for the default path.
metadata.rb
Outdated
| @@ -5,7 +5,7 @@ | |||
| license 'Apache-2.0' | |||
| description 'Allows for fetching and executing compliance profiles, and reporting its results' | |||
| long_description IO.read(File.join(File.dirname(__FILE__), 'README.md')) | |||
| version '5.0.4' | |||
| version '5.0.5' | |||
There was a problem hiding this comment.
Gotta be a major bump for a change like this.
jquick
force-pushed
the
jq/enable_inspec_caching
branch
from
0bea7c9 to
34c4640
Compare
Signed-off-by: Jared Quick <jquick@chef.io>
jquick
force-pushed
the
jq/enable_inspec_caching
branch
from
34c4640 to
dda288b
Compare
Signed-off-by: Jared Quick <jquick@chef.io>
jquick
force-pushed
the
jq/enable_inspec_caching
branch
from
0abcd87 to
76c3689
Compare
|
These issues have been resolved. |
adamleff
added
Status: Maintainer Review Needed
and removed
Status: Pending Contributor Response
labels
Description
Add inspec caching attribute which defaults to true. This enables the new inspec caching when used by the Audit cookbook.
Issues Resolved
Fixes #296
Signed-off-by: Jared Quick jquick@chef.io