Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Audit cookbook to support ChefClient 14 #313

Merged
merged 3 commits into from
Apr 19, 2018
Merged

Conversation

jquick
Copy link
Contributor

@jquick jquick commented Apr 18, 2018

Signed-off-by: Jared Quick jquick@chef.io

Description

This fixes the resource version issue with ChefClient 14.

Issues Resolved

Fixes #312

Check List

@jquick jquick requested a review from a team April 18, 2018 18:25
Signed-off-by: Jared Quick <jquick@chef.io>
@jquick jquick force-pushed the jq/fix_chefclient14 branch from 8114287 to 60ecc89 Compare April 18, 2018 18:29
Copy link
Contributor

@jerryaldrichiii jerryaldrichiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Signed-off-by: Jared Quick <jquick@chef.io>
@jquick jquick force-pushed the jq/fix_chefclient14 branch from 2b9824a to 137314a Compare April 19, 2018 13:16
@jquick
Copy link
Contributor Author

jquick commented Apr 19, 2018

Updated the tests here as json['controls'] was removed from the json report in inspec 2.0. Also bound kitchen-dokken to a working version. Newer versions do not allow the kitchen cache to be accessed in the validation stage.

@jquick
Copy link
Contributor Author

jquick commented Apr 19, 2018

Tested on both 13/14 client versions.

@jquick
Copy link
Contributor Author

jquick commented Apr 19, 2018

Should minor bump for this when released.

Copy link
Contributor

@chris-rock chris-rock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @jquick

@jquick jquick merged commit a7ca7d2 into master Apr 19, 2018
@jquick jquick deleted the jq/fix_chefclient14 branch April 19, 2018 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Support ChefClient 14
4 participants