Remove compliance and visibility reporters #383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alexpop per #241, yeah, can we clean up the reference in this doc? |
|
@alexpop ping |
|
ya, +1 on the cleanup, the original compliance has been eol for a while now |
alexpop
added
Priority: Medium
Size: L
and removed
Aspect: Documentation
Priority: Low
labels
alexpop
changed the title
vjeffrey
reviewed
Sep 18, 2019
| ['audit']['reporter'] = 'chef-compliance' | ||
| ['audit']['fetcher'] = 'chef-server' | ||
| ['audit']['server'] = 'https://compliance-server.test/api' | ||
| ['audit']['refresh_token' OR 'token'] = '..' |
There was a problem hiding this comment.
removing all this cruft is going to make this SO much more readable 🎉
alexpop
force-pushed
the
ap/update-supported-confs
branch
from
0b9c281 to
b724299
Compare
Signed-off-by: Alex Pop <apop@chef.io>
…hef-server-visibility. Gone! Signed-off-by: Alex Pop <apop@chef.io>
Signed-off-by: Alex Pop <apop@chef.io>
Signed-off-by: Alex Pop <apop@chef.io>
Signed-off-by: Alex Pop <apop@chef.io>
alexpop
force-pushed
the
ap/update-supported-confs
branch
from
b724299 to
7bf06ec
Compare
|
Merging this now as #385 went in as well |
stevendanna
added a commit
to stevendanna/audit
that referenced
this pull request
Sep 19, 2019
This function was removed in chef-boneyard#383, likely because the original comment on the function indicated that this was related to downloaded profiles specifically from compliance. In reality, this function overrides a function in the inspec Url fetcher. It overrides it so that it can use the Chef::ServerAPI client. This client will use Chef Server's header based authentication, allowing chef-clients to report audit data with a specific data collector token. Signed-off-by: Steven Danna <steve@chef.io>
alexpop
pushed a commit
that referenced
this pull request
Sep 19, 2019
This function was removed in #383, likely because the original comment on the function indicated that this was related to downloaded profiles specifically from compliance. In reality, this function overrides a function in the inspec Url fetcher. It overrides it so that it can use the Chef::ServerAPI client. This client will use Chef Server's header based authentication, allowing chef-clients to report audit data with a specific data collector token. Signed-off-by: Steven Danna <steve@chef.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #241
@vjeffrey @kekaichinose, should be also cleanup any doc references to the integration with the original Compliance product?