improve compliance refresh token handling #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris-rock
force-pushed
the
chris-rock/compliance_refresh_token
branch
from
c5e1bbc to
35f3ab5
Compare
| action :install do | ||
| converge_by 'install/update inspec' do | ||
| chef_gem 'inspec' do | ||
| version version if version != 'latest' |
There was a problem hiding this comment.
@chris-rock I get an WARN on line 15 version
Recipe: audit::_inspec
* inspec[inspec] action install[2016-08-25T13:28:53+00:00] WARN: /var/chef/cache/cookbooks/audit/libraries/inspec.rb:15:in `block (3 levels) in <class:ChefInspec>': property version is declared in both chef_gem[inspec] and inspec[inspec] action :install. Use new_resource.version instead. At /var/chef/cache/cookbooks/audit/libraries/inspec.rb:15:in `block (3 levels) in <class:ChefInspec>'
[2016-08-25T13:28:53+00:00] WARN: /var/chef/cache/cookbooks/audit/libraries/inspec.rb:15:in `block (3 levels) in <class:ChefInspec>': property version is declared in both chef_gem[inspec] and inspec[inspec] action :install. Use new_resource.version instead. At /var/chef/cache/cookbooks/audit/libraries/inspec.rb:15:in `block (3 levels) in <class:ChefInspec>'
This doc seems to support the WARN message above:
https://docs.chef.io/custom_resources.html#new-resource-property
When I test changing line 15 to the following I no longer get the WARNing, and the gem is installed correctly at the expected version.
version new_resource.version if new_resource.version != 'latest'
|
Added a few comments above. Otherwise this PR looks awesome and will be super helpful. Tested the PR itself and works like charm! Very nice @chris-rock! 👍 |
chris-rock
force-pushed
the
chris-rock/compliance_refresh_token
branch
from
35f3ab5 to
b231d30
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is doing the following:
Issues Resolved
Customers reported that
refresh_tokenhandling was not working as expected and lead to authentication errors for some requests.Check List