Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Knife bootstrap custom client.rb config #183

Merged
merged 4 commits into from
Feb 18, 2016
Merged

Conversation

jaym
Copy link
Contributor

@jaym jaym commented Feb 2, 2016

Knife bootstrap currently only allows a select few client.rb parameters
to be specified during bootstrap. This RFC is an attempt to allow users
to be able to specify client.rb parameters that are not directly known
to knife bootstrap.

Knife bootstrap currently only allows a select few `client.rb` parameters
to be specified during bootstrap. This RFC is an attempt to allow users
to be able to specify `client.rb` parameters that are not directly known
to knife bootstrap.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This RFC proposes a solution to allow users to pass bulk configuration data to knife bootstrap to be placed in the client.rb before the first chef-client run.


## Background

The `knife-bootstrap` command supports a small subset of possible parameters
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

*knife bootstrap (no dash)

@jaym jaym changed the title Knife bootstrap custom client.rb config WIP Knife bootstrap custom client.rb config Feb 4, 2016
@adamhjk
Copy link
Contributor

adamhjk commented Feb 4, 2016

I am the decider, and I approve this RFC. Take it away @chef/rfc-editors

gif-keyboard-5291699247265849886

switch `--client_d_dir`. The files will be loaded in alphabetical
order. Knife will still sync all files under `client.d`, however
only top-level files will the automatically loaded. The block to
do this would look something like:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we were talking in IRC today, the client_d directory should default to like #{Chef::Config[:config_dir]}/client.d" and should be a Chef::Config setting like Chef::Config[:client_d_dir] that you could override in your knife.rb or client.rb or whatever. but don't add a CLI arg like --client_d_dir unless we're convinced we need it.

@nathenharvey
Copy link
Contributor

@chef/rfc-editors this looks decided, can you merge or should it be a topic at our next meeting?

@adamleff
Copy link
Contributor

@nathenharvey I was holding off to see if @btm's comment was addressed, and it appears it has. 😄 I will merge.

adamleff added a commit that referenced this pull request Feb 18, 2016
Knife bootstrap custom client.rb config
@adamleff adamleff merged commit 498562a into master Feb 18, 2016
@adamleff adamleff deleted the jdm/knife-bootstrap branch February 18, 2016 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants