CHEF-4553: DSL support for customizable guards for powershell_script, bash, et. al resource scenarios #5
Conversation
|
+1 This would really help me keep my guards for the powershell_script resource easier and cleaner. |
| environment variable, alternate user identity, or current directory, and | ||
| testing the current state to ensure idempotence through a guard requires the | ||
| same state. Inheritance enables that state to be expressed exactly once | ||
| through the Chef DSL. |
There was a problem hiding this comment.
Does it make sense to make it inherit more narrowly, only when the parent resource is the same class as the guard resource? Or are you purposefully allowing for different classes of execute resources to inherit cwd? I can see the utility in duck typing this way, but I can also see a possible edge case where the name of an attribute in the parent might be the same but the parent might be some strange LWRP with different semantics and this causes surprise.
There was a problem hiding this comment.
Very good point. At the very least, it should probably be limited to cases where the class in the guard expression is a derived class of the parent. Then there can't be a conflict, since those attributes must already be defined by the parent.
|
@adamedx is there more to do before merging this? the implementation's done now, right? |
|
Yes, but the doc hasn't been updated, so I'll do a merge after I finish the updates that take into account the final feedback (i.e. what was actually implemented). |
…r powershell_script
…urrent session scope
CHEF-4553: DSL support for customizable guards for powershell_script, bash, et. al resource scenarios
I'm still updating this, but I think there's enough here to comment.
One thing I don't like: not sure the name "anonymous resource" is what I'm really looking for here -- suggestions welcome!