Fix regression with gpg attribute
#8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In commit 50f5fa4, we fixed the recipes to use the right attribute, gpg instead of key. However, the logic in the attributes file looks for /opt/opscode/embedded/keys/packages-chef-io-public.key and sets the key attribute to that file path. This causes the apt_repository provider logic to try and use a cookbook_file resource to retrieve that, which cannot be found. The fix is to set the value to nil if the key file exists from a Chef Server package, because we know we'll have the key from a previous installation. This only manifested when using a recipe with `chef_ingredient "chef-server"`, and could not be reproduced on a clean `kitchen test`.
|
👍 |
1 similar comment
|
👍 |
jtimberman
added a commit
that referenced
this pull request
Dec 18, 2015
Fix regression with `gpg` attribute
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6, #7
In commit 50f5fa4, we fixed the recipes to use the right attribute,
gpg instead of key. However, the logic in the attributes file looks
for /opt/opscode/embedded/keys/packages-chef-io-public.key and sets
the key attribute to that file path. This causes the apt_repository
provider logic to try and use a cookbook_file resource to retrieve
that, which cannot be found. The fix is to set the value to nil if the
key file exists from a Chef Server package, because we know we'll have
the key from a previous installation.
This only manifested when using a recipe with
chef_ingredient "chef-server", and could not be reproduced on a cleankitchen test.