Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHEF-11758] Simplify the restore command #8469

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

deenchev
Copy link
Collaborator

πŸ”© Description: What code changed, and why?

⛓️ Related Resources

πŸ‘ Definition of Done

πŸ‘Ÿ How to Build and Test the Change

βœ… Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

πŸ“· Screenshots, if applicable

Signed-off-by: deenchev <deenchev@progress.com>
Copy link

netlify bot commented Jun 20, 2024

πŸ‘· Deploy Preview for chef-automate processing.

Name Link
πŸ”¨ Latest commit b4bd923
πŸ” Latest deploy log https://app.netlify.com/sites/chef-automate/deploys/668e44eb24b3650007afc29d

@deenchev deenchev force-pushed the chef-11758/simplify_restore_command branch from cd818aa to 23c95b3 Compare June 20, 2024 10:54
Signed-off-by: deenchev <deenchev@progress.com>
…uce interactive behavior in case of error

Signed-off-by: deenchev <deenchev@progress.com>
@deenchev deenchev force-pushed the chef-11758/simplify_restore_command branch from 4cdeb26 to b5f97ca Compare June 28, 2024 09:12
…e comparisons

Signed-off-by: deenchev <deenchev@progress.com>
Signed-off-by: deenchev <deenchev@progress.com>
@jayvikramsharma1
Copy link
Collaborator

Please attach demo video for both S3 backup and ECS backups

Copy link
Collaborator

@vivekshankar1 vivekshankar1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add a demo video

Quality Gate failed Quality Gate failed

Failed conditions
2 New issues
0.8% Coverage on New Code (required β‰₯ 80%)

See analysis details on SonarQube

Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants