Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename centos images for clarity #406

Merged
merged 1 commit into from
Sep 9, 2015

Conversation

patcon
Copy link
Contributor

@patcon patcon commented Jul 16, 2015

Perhaps I'm mistaken, but I CentOS minor versions are a little misleading, since the minor versions will automatically bump to the most recent available on yum update:
https://unix.stackexchange.com/questions/60660/minor-upgrades-and-version-numbers-on-centos

So even if someone downloaded as old 6.5 image, the normal update process brings them to 6.6. Thinking perhaps we could just say centos-6 and centos-7 for clarity.

@legal90
Copy link
Contributor

legal90 commented Aug 25, 2015

@cheeseplus, @fnichol What do you think about it?

@patcon
Copy link
Contributor Author

patcon commented Aug 25, 2015

Last comment: Yes, minor version is arguably important, but it's akin to having an ubuntu slug of ubuntu-14.04.2 (as I understand it :)

Simpler slug would mean you could just update the box in the atlas directory (with the same centos-7 slug name), and use their box updater feature without being inconsistent

@cheeseplus
Copy link
Contributor

I'm generally onboard with this as I can't think of a downside and this maps to how the distro itself works. I'll chat with @fnichol and see if there is anything preventing us from making the switch.

@yzl
Copy link

yzl commented Sep 8, 2015

lgtm

cheeseplus pushed a commit that referenced this pull request Sep 9, 2015
@cheeseplus cheeseplus merged commit 6d7a739 into chef:master Sep 9, 2015
@patcon patcon deleted the feature/rename-centos-slug branch September 9, 2015 20:41
@cheeseplus
Copy link
Contributor

So I reverted this merge for two reasons:

  1. it was based off the 6.6 defintions
  2. upon reflection we've identified use cases where folks will want specific, instead of just HEAD

For 2 we realize that many people want the old versions to test upgrades or have env restrictions. It's a difference between the reality of how people are constrained vs what version should be ideally used. We discussed making a slug for centos-7 that points at latest but at the same time supporting MAJ.MIN as we already have and making it consistent across the distros.

@tas50 tas50 added Triage: Needs Information Indicates an issue needs more information in order to work on it. Type: Enhancement Adds new functionality. and removed Feedback Requested labels Jan 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Triage: Needs Information Indicates an issue needs more information in order to work on it. Type: Enhancement Adds new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants