-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Freebsd 10.2 #424
Freebsd 10.2 #424
Conversation
ISO URLs updated ISO Checksums updated HTTP Install script path updated
The FreeBSD 10.2 freebsd-update utility supports a `--not-running-from-cron` argument, so patching it to run without a TTY is no longer required. Fix failed fetching of files caused by empty proxy environment variables. Note that freebsd-update fetch & install will break if there arent any patches available for the release. I've tried to handle the install case when no updates are needed by capturing the fetch output and checking the last line. This results in some odd behaviour when there are updates available and causes the install to fail completely. As such I've removed these changes.
This is great @geoffgarside as I was encountering this while testing a build pipeline. I think the right approach here is to make an additional commit to catch and hanlde an already up-to-date install (no updates available) |
I'm not quite sure how to test this now. FreeBSD 10.2 now has a p1 set of updates. What I tried however was this env PAGER=/bin/cat $freebsd_update fetch | tee /tmp/freebsd-update-fetch.log
tail -n1 /tmp/freebsd-update-fetch.log | grep "No updates needed"
if [ $? -eq 0 ]; then
env PAGER=/bin/cat $freebsd_update install
fi unfortunately if there are updates available this screws up as it appears to execute the tail/grep in the middle of I'm happy to try and fix it as part of this PR, but I'm a bit lost on how to actually fix it... |
Huh, didn't think we'd get a less-automatable system update here 😿 |
I think the previous versions of Its annoying that theres no good way to tell from the return code of |
In the interest of functioning > perfect I'm giving this a +1 as it allows us to build 10.2 |
Update FreeBSD 10.1 manifests to 10.2.
Change the freebsd-update part as it now supports a
--not-running-from-cron
argument to be used with automated tools. We check the major_version to see if it should be supported or not.I've also added a note in that the current update.sh will fail when the FreeBSD release being installed doesn't have any updates available as the
freebsd-update install
will return an errcode 1 which will cause the shell (running with-e
) to bail out.If you'd rather the commits were squashed let me know and I can sort that.