Remove CentOS requiretty sudoers workaround, this is now the default #740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry, I'd forgotten about the new DCO stuff. I amended the commit to include 'Obvious fix' and force pushed, but it seems the check still fails. Let me know if you need me to close and reopen. |
|
|
CentOS 7.3 includes sudo-1.8.6p7-21 which disables requiretty by default. CentOS 6 has not required this since at least 6.8. Obvious fix. Signed-off-by: mvermaes <mvermaes@gmail.com>
|
Ah sorry about that, I didn't realize |
|
@mvermaes The DCOBot should have recognized "obvious fix" declared in the commit message. Thank you for signing off anyway. We'll check on the bot and make sure the reveries update didn't corrupt something. |
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CentOS 7.3 includes
sudo-1.8.6p7-21which disables requiretty by default.CentOS 6 has not required this since at least 6.8.
See CentOS/sig-cloud-instance-build#78 for more details.