Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds generate subcommands for Compliance Phase objects #205

Merged
merged 4 commits into from
Feb 2, 2022
Merged

Adds generate subcommands for Compliance Phase objects #205

merged 4 commits into from
Feb 2, 2022

Conversation

collinmcneese
Copy link
Contributor

Signed-off-by: Collin McNeese cmcneese@chef.io

Description

  • Adds chef generate sub-commands waiver, input and profile for Compliance Phase objects
  • Adds creation of compliance directory to default chef generate cookbook output with a README file located at ./compliance/README.md describing the purpose of the directory.
  • Re-locates license case logic for matching argument text to output text to ChefCLI::Generator::TemplateHelper so that it can be used for both Cookbook generation and compliance Profile generation (DRY).
  • Updates the chef generate ... subcommands to be in alphabetical order.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

Collin McNeese added 2 commits February 1, 2022 14:54
Adds generate subcommands for Compliance Phase objects
e4b0168 
Signed-off-by: Collin McNeese <cmcneese@chef.io>
chefstyle fixes
5dc3019 
Signed-off-by: Collin McNeese <cmcneese@chef.io>
@collinmcneese collinmcneese marked this pull request as ready for review February 1, 2022 23:22
@collinmcneese collinmcneese requested review from a team as code owners February 1, 2022 23:22
@tas50
Copy link
Contributor

tas50 commented Feb 1, 2022

Resolves chef/chef-workstation#2542
Resolves chef/chef-workstation#2541

wording updates and uses chefcli dist constants
ffa5574 
Signed-off-by: Collin McNeese <cmcneese@chef.io>
adds additional chefcli::dist updates
34ab4fb 
Signed-off-by: Collin McNeese <cmcneese@chef.io>
@tas50
Copy link
Contributor

tas50 commented Feb 2, 2022

I've tested this locally and it works as expected

@tas50 tas50 added the Expeditor: Bump Version Minor Used by github.minor_bump_labels to bump the Minor version number. label Feb 2, 2022
@marcparadise marcparadise merged commit 70f3fe3 into chef:main Feb 2, 2022
@collinmcneese collinmcneese deleted the cmcneese/generate_compliance branch February 3, 2022 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikhil2611 nikhil2611 nikhil2611 approved these changes

@tas50 tas50 tas50 approved these changes

@i5pranay93 i5pranay93 Awaiting requested review from i5pranay93

@snehaldwivedi snehaldwivedi Awaiting requested review from snehaldwivedi

Assignees
No one assigned
Labels
Expeditor: Bump Version Minor Used by github.minor_bump_labels to bump the Minor version number.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@collinmcneese @tas50 @nikhil2611 @marcparadise