Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update generator kitchen templates for modern platforms #234

Merged
merged 6 commits into from
Aug 17, 2024

Conversation

Stromweld
Copy link
Contributor

Description

Updated the generator kitchen templates for latest chef_infra provisioner name, and update platforms for latest current versions now that centos is EOL.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • If Gemfile.lock has changed, I have used --conservative to do it and included the full output in the Description above.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
@Stromweld Stromweld requested review from a team as code owners July 16, 2024 16:50
Copy link

Simplecov Report

Covered Threshold
98.51% 90%

Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
Signed-off-by: Corey Hemminger <hemminger@hotmail.com>
@nikhil2611
Copy link
Contributor

Hey @Stromweld ,The verify pipeline is failing here. I'll try to fix it.

@Stromweld
Copy link
Contributor Author

thanks @nikhil2611

Signed-off-by: nikhil2611 <nikhilgupta2102@gmail.com>
Signed-off-by: nikhil2611 <nikhilgupta2102@gmail.com>
Copy link

sonarcloud bot commented Aug 14, 2024

Quality Gate failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
33.8% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube

@Stromweld
Copy link
Contributor Author

looks like the only 2 failing tests are unrelated to the work here.

@Stromweld
Copy link
Contributor Author

I don't have perms to merge, @nikhil2611 @sanjain-progress @ashiqueps one you of you will have to merge this when your ready.

@nikhil2611
Copy link
Contributor

I don't have perms to merge, @nikhil2611 @sanjain-progress @ashiqueps one you of you will have to merge this when your ready.

Sure I'll do that. Thanks

@nikhil2611 nikhil2611 merged commit d86c662 into main Aug 17, 2024
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants