Fix multiple requests to Chef server #365
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kirill Lyubchenko <kirill.lyubchenko@applovin.com>
* Converted tmpcache to hash, renamed variable * Re-initialize hash in delete method Signed-off-by: Kirill Lyubchenko <kirill.lyubchenko@applovin.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce the number of requests to Chef server for secrets in sparse mode.
Description
We noticed that when loading a secret in sparse mode, chef-vault makes as much as six requests to Chef server while retrieving the client's data bag encryption key, which is caused by multiple calls of
sparse_keymethod. These changes reduce the number of such requests to one.Types of changes
Checklist: