Policyfile Revision ID Validation.

[danielsdeleo]

In the Policyfile draft RFC, revision_id is a required field. Add this validation to Chef Zero. This works locally with changes to pedant, but I can't commit those because erchef's policyfile validation is broken.

See Also:

• ChefDK PR: Policyfile Revision IDs chef-boneyard/chef-dk#323
• Pedant: Verify that policyfiles have a valid revision id field chef-boneyard/chef-pedant#100
• Policyfile Draft RFC: Policyfile HTTP Document API chef-boneyard/chef-rfc#91

[jkeiser]

👍 for code. Let's see what the failures are though ...

[jkeiser]

Oh, right. Corresponding pedant changes in progress :) 👍 once you update the pedant SHA to a passing one :)

[danielsdeleo]

Thanks for review. Now that I got pedant merged, I'll update that.

[danielsdeleo]

Ugh, this is a weird one. When I give a policy with a 255 character name, Zero gets this error:

[2015-02-26T21:56:22+00:00] ERROR: #<Errno::ENAMETOOLONG: File name too long @ rb_sysopen - /tmp/d20150226-2418-ftq19p/repo/policies/some_policy_group/aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa.json>

Which is really weird, because:

'/tmp/d20150226-2418-ftq19p/repo/policies/some_policy_group/aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa.json'.size
#=> 319

And yet the manual states:

ENAMETOOLONG
The length of the path argument exceeds {PATH_MAX} or a pathname component is longer than {NAME_MAX}.

And the internet says that on Linux, PATH_MAX is 4096.