Make user and client keys endpoints pass Pedant specs #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 16, 2016
| # We grab the old data to trigger a 404 if it doesn't exist | ||
| get_data(request, data_path(request)) | ||
|
|
||
| set_data(request, path, request.body) |
There was a problem hiding this comment.
Seems odd that this does not need a special case for the default key
There was a problem hiding this comment.
Hmm, that does seem odd. I'll take a closer look.
|
There were two things I didn't understand. Also, I'm assuming we need to merge the chef change to make travis happy. Everything else is 👍 Really like the logging and test running improvements. |
jrunning
force-pushed
the
jr/pedant-keys-2
branch
from
3637803
to
d86ea51
Compare
jrunning
force-pushed
the
jr/pedant-keys-2
branch
from
d86ea51
to
d76f96b
Compare
danielsdeleo
force-pushed
the
jr/pedant-keys-2
branch
from
d76f96b
to
b81980a
Compare
- Implement ActorKeyEndpoint, ActorKeysEndpoint.
- Implement user, client keys in `ActorEndpoint#delete`, `#put`.
- RestBase
- Fix RestErrorResponse exceptions to report actual `rest_path`
instead associated with the failed data store operation instead of
`request.rest_path`.
- Move `json_response`, `already_json_response` args `request_version`
and `response_version` into options hash; add docs.
- DataError, RestErrorResponse: Pass useful message text to `super`.
- RestRouter: Clean up logging
- Print request methods, paths and bodies more readably for log_level >= INFO.
- Pretty-print RestRequest objects (only printed when log_level == DEBUG).
- Server: Change default log_level to `:warn` (to enable logging cleanup above).
- `Rakefile`, `spec/run_oc_pedant.rb`
- Consume RSpec, Pedant options from `ENV['RSPEC_OPTS']`, `ENV['PEDANT_OPTS']` (see `rake -D`).
- Consume `ENV['LOG_LEVEL'` (see `rake -D`).
- Clean up ChefZero::Server default opts and move duplicated logic to `start_chef_server` method.
jrunning
force-pushed
the
jr/pedant-keys-2
branch
from
b81980a
to
b0971ce
Compare
|
@chef/client-dev-tools can I get another review on this? |
|
👍, this has a lot of great simplification too! Awesome job. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on chef/chef#4587 and chef/chef-server#740.
ActorEndpoint#delete,#put.rest_pathinstead associated with the failed data store operation instead of
request.rest_path.json_response,already_json_responseargsrequest_versionand
response_versioninto options hash; add docs.super.:warn(to enable logging cleanup above).Rakefile,spec/run_oc_pedant.rbENV['RSPEC_OPTS'],ENV['PEDANT_OPTS'](seerake -D).ENV['LOG_LEVEL'(seerake -D).start_chef_servermethod.