-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement rfc090 for named nodes endpoint #264
Conversation
Signed-off-by: Jeremy J. Miller <jm@chef.io>
200
404
|
Hmm, all the build failures seem non-related to this change and from oc_id
|
Signed-off-by: Jeremy J. Miller <jm@chef.io>
Signed-off-by: Jeremy J. Miller <jm@chef.io>
Signed-off-by: Jeremy J. Miller <jm@chef.io>
.travis.yml
Outdated
@@ -15,6 +15,9 @@ cache: bundler | |||
script: | |||
- bundle update | |||
- bundle exec rake pedant | |||
env: | |||
global: | |||
- "PEDANT_OPTS=\"--skip-oc_id\"" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should just land in https://github.com/chef/chef-zero/blob/master/spec/run_oc_pedant.rb#L149 since it'll always be needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks - makes sense!
Signed-off-by: Jeremy J. Miller <jm@chef.io>
I can squash commits if needed. |
Thanks Jeremy! |
This is a first stab at implementing rfc090 (HTTP HEAD) support.
For right now, it only covers the named nodes endpoint ('/nodes/NAME'). However, it can easily be added to other endpoints as needed.
Signed-off-by: Jeremy J. Miller jm@chef.io