fixup end_range typos #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The patch looks good! Just so I'm clear, is there a bug here beyond the error message? i.e. did you type a valid search but it choked anyway? |
|
Right the valid searches were failing to parse because the end was looking
|
|
Yoink! I totally missed that bit of the line. Good catch, and still correct patch. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there. I found what I thought might be a couple of typos when CZ tries to parse some of my chef searches.
The braces look like they are facing the wrong way for "normal" range queries, and then when it tried to throw the error there was a missing "expected_end_range" variable. I think this is what was intended.