improve depsolver error message #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- at least return the last cookbook that failed inside the recursive bowels of the depsolver. not sure if this will produce a slightly misleading error messge in the case of a cookbook resolution failure, but it should give at least point at a cookbook that has a problem.
|
I think we should refactor the depsolver into its own class (or use an existing one) and actually return an object that has methods such as |
|
well, i got (notimeforthat), but sure... in the meantime, though, the existing error messages are completely unusable if you've got a mess of deps... |
|
(we also keep talking about nuking the depsolver out of the server, in which case this code already has an execution date...) |
|
This is significantly better than what we have, which is nothing. |
jkeiser
added a commit
that referenced
this pull request
Oct 29, 2013
improve depsolver error message
|
thanks for merging this!! 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bowels of the depsolver. not sure if this will produce a slightly
misleading error messge in the case of a cookbook resolution failure,
but it should give at least point at a cookbook that has a problem.