Remove use_automatic_resource_name, make resource_name automatic #3495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkeiser
force-pushed
the
jk/automatic-automatic-name
branch
from
dc4d691
to
75e568e
Compare
jkeiser
force-pushed
the
jk/automatic-automatic-name
branch
from
ead95ec
to
9812b59
Compare
jkeiser
changed the title
jkeiser
force-pushed
the
jk/automatic-automatic-name
branch
from
9812b59
to
49bfaea
Compare
jkeiser
force-pushed
the
jk/automatic-automatic-name
branch
from
6c24575
to
34bbfb6
Compare
| @@ -17,11 +17,12 @@ | |||
| * [pr#3397](https://github.com/chef/chef/pull/3397): Validate owner exists in directory resources | |||
| * [pr#3418](https://github.com/chef/chef/pull/3418): Add `shell_out` mixin to Chef::Resource class for use in `not_if`/`only_if` conditionals, etc. | |||
| * [pr#3406](https://github.com/chef/chef/pull/3406): Add wide-char 'Environment' to `broadcast_env_change` mixin for setting windows environment variables | |||
| * [pr#3442](https://github.com/chef/chef/pull/3442): Add `resource_name` to top-level Resource class to make defining resources easier. `use_automatic_resource_name` also added, to support convention-based resource naming. | |||
| * [pr#3442](https://github.com/chef/chef/pull/3442): Add `resource_name` to top-level Resource class to make defining resources easier. | |||
There was a problem hiding this comment.
This changelog entry might be confusing as it looks like that PR was closed and not merged?
There was a problem hiding this comment.
It was merged actually. Not sure why it says that ...
jkeiser
force-pushed
the
jk/automatic-automatic-name
branch
from
34bbfb6
to
d795db9
Compare
|
@thommay all things fixed! |
|
|
||
| # `provides :resource_name, os: 'linux'`) needs to remove the old | ||
| # canonical DSL before adding the new one. | ||
| if @resource_name && name == @resource_name |
There was a problem hiding this comment.
is the first check for @resource_name needed?
can name be nil?
|
👍 |
thommay
added a commit
that referenced
this pull request
Jun 9, 2015
Remove use_automatic_resource_name, make resource_name automatic
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.