Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing Issue #2513 - the broken render of nested partial templates #3510

Merged
merged 1 commit into from
Sep 2, 2015

Conversation

ckaushik
Copy link
Contributor

@ckaushik ckaushik commented Jun 9, 2015

Adding the instance variable @template_finder to the new TemplateContext class for rendering partials

@chef-supermarket
Copy link

Hi. I am an automated pull request bot named Curry. There are commits in this pull request whose authors are not yet authorized to contribute to Chef Software, Inc. projects or are using a non-GitHub verified email address. To become authorized to contribute, you will need to sign the Contributor License Agreement (CLA) as an individual or on behalf of your company. You can read more on Chef's blog.

GitHub Users Who Are Not Authorized To Contribute

The following GitHub users do not appear to have signed a CLA:

Please sign the CLA here.

@chef-supermarket
Copy link

Hi. Your friendly Curry bot here. Just letting you know that all commit authors have become authorized to contribute. I have added the "Signed CLA" label to this issue so it can easily be found in the future.

@samdunne
Copy link
Contributor

Can someone look at this?

@thommay
Copy link
Contributor

thommay commented Jul 22, 2015

This looks reasonable; 👍
@chef/client-core

@tyler-ball
Copy link
Contributor

Can https://github.com/chef/chef/blob/master/spec/unit/mixin/template_spec.rb be updated with a test for this?

@danielsdeleo
Copy link
Contributor

I'm okay to merge if we need it now to fix the broken, but this really deserves a regression test to ensure it works in the future.

@ckaushik
Copy link
Contributor Author

Can we merge it now to fix the broken template rendering?
On Jul 23, 2015 12:05 PM, "Dan DeLeo" notifications@github.com wrote:

I'm okay to merge if we need it now to fix the broken, but this really
deserves a regression test to ensure it works in the future.


Reply to this email directly or view it on GitHub
#3510 (comment).

@samdunne
Copy link
Contributor

I added regression testing here: ckaushik#1

@ckaushik will you merge this into your PR?

cc/ @tyler-ball, @danielsdeleo

…s with variables

Authors: Kaushik C <kaushik.chand@gmail.com>, Sam Dunne <sam@sam-dunne.com>
@ckaushik
Copy link
Contributor Author

@danielsdeleo does this look good for merging?

@danielsdeleo
Copy link
Contributor

Nice! 👍

@tyler-ball
Copy link
Contributor

👍

thommay added a commit that referenced this pull request Sep 2, 2015
Fixing Issue #2513 - the broken render of nested partial templates
@thommay thommay merged commit b25ff49 into chef:master Sep 2, 2015
@ckaushik ckaushik deleted the issue_2513 branch September 2, 2015 17:28
@chef chef locked and limited conversation to collaborators Nov 16, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants