Use windows paths without case-sensitivity. #3572
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @chef/client-windows |
ksubrama
force-pushed
the
ksubrama/path_space
branch
from
7d60658
to
e2641bb
Compare
ksubrama
force-pushed
the
ksubrama/path_space
branch
from
e2641bb
to
a1ad91b
Compare
| result = Chef::ChefFS::PathUtils.join(*(['..']*(source_parts.length-i) + dest_parts[i,dest.length-i])) | ||
| result == '' ? '.' : result | ||
| end | ||
| # A Chef-FS path is a path in a chef-repository that can be used to address |
There was a problem hiding this comment.
/cc @charlesjohnson You wanted doc details for Chef-FS paths.
ksubrama
force-pushed
the
ksubrama/path_space
branch
from
a1ad91b
to
c9e2311
Compare
|
👍 |
| else | ||
| path.to_s | ||
| # | ||
| # TODO: Move this to wherever util/path_helper is these days. |
There was a problem hiding this comment.
Looks like chef-config/path_helper? Though I wonder how much sense that makes...
|
👍 |
ksubrama
force-pushed
the
ksubrama/path_space
branch
from
c9e2311
to
ee67daf
Compare
ksubrama
force-pushed
the
ksubrama/path_space
branch
from
ee67daf
to
f325026
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #1684