Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use require_paths and not path so bundler grabs all paths from a git reference #4459

Merged
merged 1 commit into from
Jan 25, 2016

Conversation

mwrock
Copy link
Member

@mwrock mwrock commented Jan 25, 2016

Using bundler to install from git via gem 'chef', github: 'chef/chef' only the last path is added to $LOAD_PATH when using require_path in gemspec. require_paths fixes this. This fixes knife-windows builds.

@danielsdeleo
Copy link
Contributor

👍

@jaym
Copy link
Contributor

jaym commented Jan 25, 2016

:shipit:

@lamont-granquist
Copy link
Contributor

👍

mwrock added a commit that referenced this pull request Jan 25, 2016
use require_paths and not path so bundler grabs all paths from a git reference
@mwrock mwrock merged commit c502256 into master Jan 25, 2016
@mwrock mwrock deleted the mwrock/appveyor branch January 25, 2016 23:52
@chef chef locked and limited conversation to collaborators Nov 16, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants