Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to support standard .aws/credentials file #305

Merged
merged 2 commits into from
Aug 25, 2015
Merged

Updates to support standard .aws/credentials file #305

merged 2 commits into from
Aug 25, 2015

Conversation

pallan
Copy link

@pallan pallan commented Jun 8, 2015

The newer version of the AWS Credentials uses the common file at ~/.aws/credentials. This is described in more detail here http://blogs.aws.amazon.com/security/post/Tx3D6U6WSFGOK2H/A-New-and-Standardized-Way-to-Manage-Credentials-in-the-AWS-SDKs

This updates the ec2 plugin to support this file and its INI format. In addition it adds support for profiles if they are defined in the credentials file. The profile can be set via a config variable in the file or via the command line,

knife[:aws_profile] = "default"
$ knife ec2 --aws-profile default ...

@chef-supermarket
Copy link

Hi. I am an automated pull request bot named Curry. There are commits in this pull request whose authors are not yet authorized to contribute to Chef Software, Inc. projects or are using a non-GitHub verified email address. To become authorized to contribute, you will need to sign the Contributor License Agreement (CLA) as an individual or on behalf of your company. You can read more on Chef's blog.

GitHub Users Who Are Not Authorized To Contribute

The following GitHub users do not appear to have signed a CLA:

Please sign the CLA here.

@chef-supermarket
Copy link

Hi. Your friendly Curry bot here. Just letting you know that all commit authors have become authorized to contribute. I have added the "Signed CLA" label to this issue so it can easily be found in the future.

elsif current_section
item = line.match(/^\s*(.+?)\s*=\s*(.+?)\s*$/) unless line.nil?
if item
map[current_section] = map[current_section] || {}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would ||= work here?

@dwradcliffe
Copy link

👍

@pallan
Copy link
Author

pallan commented Jul 10, 2015

Updated file reading code based on feedback

@pallan
Copy link
Author

pallan commented Aug 10, 2015

Is there anything additional that is needed to get this PR approved and merged?

@dwradcliffe
Copy link

ping @NimishaS @juliandunn for review please :)

@juliandunn
Copy link
Contributor

paging @mattray @ryancragun

@ryancragun
Copy link

👍

juliandunn added a commit that referenced this pull request Aug 25, 2015
Updates to support standard .aws/credentials file
@juliandunn juliandunn merged commit 5f7e5b3 into chef:master Aug 25, 2015
@pallan pallan deleted the aws-creds branch September 11, 2015 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants