Drop Ruby 2.2 + Add Chefstyle + align testing with other projects #530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tim Smith <tsmith@chef.io>
This is the default now Signed-off-by: Tim Smith <tsmith@chef.io>
All formatting changes Signed-off-by: Tim Smith <tsmith@chef.io>
Signed-off-by: Tim Smith <tsmith@chef.io>
This adds chefstyle which is going to fail Signed-off-by: Tim Smith <tsmith@chef.io>
Signed-off-by: Tim Smith <tsmith@chef.io>
Signed-off-by: Tim Smith <tsmith@chef.io>
Signed-off-by: Tim Smith <tsmith@chef.io>
Signed-off-by: Tim Smith <tsmith@chef.io>
Chefstyle autocorrects to 2.3+ and Chef 13+ doesn't support 2.2. It's EOL for our products. Signed-off-by: Tim Smith <tsmith@chef.io>
tas50
changed the title
We can probably avoid this except in chef/chef Signed-off-by: Tim Smith <tsmith@chef.io>
stuartpreston
approved these changes
Jul 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove Ruby 2.2 which wasn't support on Chef 13.
Pull in our standard gemfile/rakefile
add Ruby 2.5.1 testing
add Chefstyle testing + fixes