Prep knife-windows v1.0.x #578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@btm you'll need to autocorrect chefstyle |
Drops requirement on knife-windows, adds requirement on chef >= 15 Requires Ruby 2.5+ Signed-off-by: Bryan McLellan <btm@loftninjas.org>
Signed-off-by: Bryan McLellan <btm@loftninjas.org>
Signed-off-by: Bryan McLellan <btm@loftninjas.org>
|
chefstyle stuff is placated. this is as green as it is going to get until we rewrite the windows portions to use core chef. |
chef-ci
added a commit
that referenced
this pull request
May 17, 2019
Obvious fix; these changes are the result of automation not creative thinking.
kvivek1115
pushed a commit
to MsysTechnologiesllc/knife-ec2
that referenced
this pull request
Jun 13, 2019
commit b7c662a Author: Bryan McLellan <btm@loftninjas.org> Date: Tue Jun 4 12:40:52 2019 -0400 [WIP] Chef 15 bootstrap without #run (chef#584) * Fix bootstrap method argument error Signed-off-by: Vivek Singh <vivek.singh@msystechnologies.com> * Rename Ec2Base#connection to Ec2Base#ec2_connection (chef#583) Refactor the server create bootstrap options - Add common_options & connection_options modules. Refactor Initial connection with the host - Add common methods required to identify the target node. - Modify and update some existing methods. Remove unused methods and default winrm for windows Add deprecated options Fix ec2 server create specs Replace ssh_port with connection_port Dup bootstrap config Inherite knife bootstrap class Signed-off-by: Vivek Singh <vivek.singh@msystechnologies.com> * Refactor #run to use from core Chef Infra instead This needs further refactor but this is a working implmentation to stop overriding #run from Chef::Knife::Bootstrap and having to duplicate so much of it here. Requires chef/chef#8628 Signed-off-by: Bryan McLellan <btm@loftninjas.org> commit d75ff03 Author: Vivek Kumar Singh <44496937+vsingh-msys@users.noreply.github.com> Date: Sat May 25 18:34:41 2019 +0530 Rename Ec2Base#connection to Ec2Base#ec2_connection (chef#583) Signed-off-by: Vivek Singh <vivek.singh@msystechnologies.com> commit dc06cf3 Author: Chef Expeditor <chef-ci@chef.io> Date: Fri May 17 21:19:06 2019 +0000 Update CHANGELOG.md with details from pull request chef#578 Obvious fix; these changes are the result of automation not creative thinking. commit b27aa92 Merge: afa4251 a3138c2 Author: Tim Smith <tsmith@chef.io> Date: Fri May 17 14:18:56 2019 -0700 Merge pull request chef#578 from chef/btm/1 Prep knife-windows v1.0.x commit a3138c2 Author: Bryan McLellan <btm@loftninjas.org> Date: Fri May 17 16:58:21 2019 -0400 Remove knife-windows requires Signed-off-by: Bryan McLellan <btm@loftninjas.org> commit a783738 Author: Bryan McLellan <btm@loftninjas.org> Date: Fri May 17 16:38:59 2019 -0400 Update chefstyle to match chef/chef:master Signed-off-by: Bryan McLellan <btm@loftninjas.org> commit 1bba1d6 Author: Bryan McLellan <btm@loftninjas.org> Date: Fri May 17 15:50:48 2019 -0400 Prep knife-windows v1.0.x Drops requirement on knife-windows, adds requirement on chef >= 15 Requires Ruby 2.5+ Signed-off-by: Bryan McLellan <btm@loftninjas.org> Signed-off-by: Vivek Singh <vivek.singh@msystechnologies.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drops requirement on knife-windows, adds requirement on chef >= 15
Requires Ruby 2.5+
Signed-off-by: Bryan McLellan btm@loftninjas.org