Fix for server-connect-attribute

[kapilchouhan99]

Signed-off-by: Kapil Chouhan kapil.chouhan@msystechnologies.com

Description

• Fix for server-connect-attribute
• Added test cases
• Ensured chef-style on the code changes made

Related Issue

Fixes: #652

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

• I have read the CONTRIBUTING document.
• I have run the pre-merge tests locally and they pass.
• I have updated the documentation accordingly.
• I have added tests to cover my changes.
• All new and existing tests passed.
• All commits have been signed-off for the Developer Certificate of Origin.

[tas50]

Shouldn't this be "returns the public host name"

[tas50]

when public DNS name is present

[tas50]

This looks like it breaks some existing functionality. The method should return nil, the private IP, or the public DNS name. We need to ensure that all 3 of those scenarios continue to function and it looks like they don't with this change. If you check the git blame on this method you should be able to track down the PRs that made this change and why they did so.

[kapilchouhan99]

This looks like it breaks some existing functionality. The method should return nil, the private IP, or the public DNS name. We need to ensure that all 3 of those scenarios continue to function and it looks like they don't with this change. If you check the git blame on this method you should be able to track down the PRs that made this change and why they did so.

Hi @tas50
Earlier this server_name method returns nil, private IP, or the public DNS name, so at that time we are setting the ssh target address according to this https://github.com/chef/knife-ec2/blob/master/lib/chef/knife/ec2_server_create.rb#L1135-L1145

so in this condition, if we set server-connect-attribute private_ip_address or vpc_mode?, then the connection_host method sets SSH target as a private IP address, and the server_name method return the Public DNS name.

So I think, this will fix all 3 of those scenarios. In this fix, we will Connect the same address as SSH Target sets.
Please give me your thoughts on this.