Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

copy missing dll to fix openssl.so issue on windows #1825

Merged
merged 3 commits into from
Oct 10, 2023
Merged

copy missing dll to fix openssl.so issue on windows #1825

merged 3 commits into from
Oct 10, 2023

Conversation

poorndm
Copy link
Collaborator

@poorndm poorndm commented Sep 20, 2023

Description

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

@poorndm
copy missing dll to chef-bin
6416a51 
Signed-off-by: poorndm <poorndm@progress.com>
@poorndm poorndm changed the title copy missing dll to fix openssl.so missing issue on windows copy missing dll to fix openssl.so issue on windows Sep 21, 2023
@poorndm
corrected the path
a8c1547 
Signed-off-by: poorndm <poorndm@progress.com>
@poorndm poorndm marked this pull request as ready for review October 10, 2023 11:13
@poorndm poorndm requested review from a team as code owners October 10, 2023 11:13
@poorndm
Update dll path
e6a9c26 
Signed-off-by: poorndm <poorndm@progress.com>
@sonarcloud
Copy link

sonarcloud bot commented Oct 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@poorndm poorndm merged commit 81746d0 into main Oct 10, 2023
4 of 5 checks passed
@poorndm poorndm deleted the poorndm/openssl-windows-fix branch October 10, 2023 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnmccrae johnmccrae johnmccrae approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@poorndm @johnmccrae