Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ruby version 3.1.4, do not change default #1827

Merged
merged 2 commits into from
Oct 7, 2023
Merged

Add ruby version 3.1.4, do not change default #1827

merged 2 commits into from
Oct 7, 2023

Conversation

clintoncwolfe
Copy link
Contributor

@clintoncwolfe clintoncwolfe commented Oct 1, 2023 •
edited
Loading

Description

Adds Ruby 3.1.4 and makes the default.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

@clintoncwolfe
Add ruby 3.1.4
2132b3c 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
@clintoncwolfe clintoncwolfe requested review from a team as code owners October 1, 2023 20:56
@clintoncwolfe clintoncwolfe changed the title Add ruby 3.1.4, make default Updated ruby version from 3.1.3 to 3.1.4 Oct 1, 2023
@clintoncwolfe
Copy link
Contributor Author

If making 3.1.4 the default makes this PR controversial or difficult to merge, I'm happy to split that out to different PR. The InSpec build needs 3.1.4 available, not the default; that just seemed to be the usual thing to do on ruby updates.

@clintoncwolfe
Revert to defaulting to 3.1.3
18d4291 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
@clintoncwolfe clintoncwolfe changed the title Updated ruby version from 3.1.3 to 3.1.4 Add ruby version 3.1.4, do not change default Oct 6, 2023
@sonarcloud
Copy link

sonarcloud bot commented Oct 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@poorndm poorndm merged commit cc36f43 into chef:main Oct 7, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tpowell-progress tpowell-progress tpowell-progress approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@clintoncwolfe @tpowell-progress @poorndm