Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ruby-msys2-devkit from 3.1.2 to 3.1.4, make config more flexible #1828

Merged
merged 2 commits into from
Oct 7, 2023
Merged

Update ruby-msys2-devkit from 3.1.2 to 3.1.4, make config more flexible #1828

merged 2 commits into from
Oct 7, 2023

Conversation

clintoncwolfe
Copy link
Contributor

@clintoncwolfe clintoncwolfe commented Oct 1, 2023 •
edited
Loading

Description

Updates ruby-msys2-devkit to add version config for 3.1.4-1.

Also adjusts the conditional logic for the config, to make it less sensitive to version changes by no longer hardcoding the ruby version in the conditionals.

Note that for this to work, the Rubyinstaller 3.1.4 exe must be uploaded to Artifactory to use internal caching.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

@clintoncwolfe
Add ruby-msys2-devkit 3.1.4
83e896d 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
@clintoncwolfe
Make ruby-msys2-devkit config less sensitive to versions
d142b6c 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
@clintoncwolfe clintoncwolfe requested review from a team as code owners October 1, 2023 23:06
@sonarcloud
Copy link

sonarcloud bot commented Oct 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
70.0% 70.0% Duplication

@poorndm poorndm merged commit 47c496a into chef:main Oct 7, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poorndm poorndm poorndm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clintoncwolfe @poorndm