forked from ibis-project/ibis
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
1 parent
497b3cb
commit 0ab34cb
Showing
4 changed files
with
47 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 comment
on commit 0ab34cb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This commit is trying to implement: ibis-project#7781. This code can work with some defects in the below example:
In [1]: import ibis
...: bq = ibis.bigquery.connect(project_id="bigframes-dev")
...: table = bq.table("bigframes-dev.ibis_gbq_testing.array_types")
...: ibis.to_sql(table.cross_join(table.x.as_table()))
...:
Named columns are not supported in table alias.
Out[1]:
SELECT
`t1`.`x`,
`t1`.`y`,
`t1`.`z`,
`t1`.`grouper`,
`t1`.`scalar_column`,
`x` AS `x_right`
FROM `bigframes-dev`.`ibis_gbq_testing`.`array_types` AS `t1`
CROSS JOIN UNNEST(`t0`.`x`) AS `t3`
- The
Named columns are not supported in table alias
error - The referred UNNEST table
t0
should be corrected ast1
This line code causes the
The Named columns are not supported in table alias error
error. We add it so that theUNNEST
node can haveTableAlias
rather thanAlias
. Becausesqlglot
expect anTableAlias
for theUNNEST
node: