fixes reading GoogleService-Info.plist on iOS #102
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chemerisuk
force-pushed
the
master
branch
11 times, most recently
from
14df41a to
09bc558
Compare
|
Seems to be fixed in the last release (2.0.3). Great job! |
|
Any timeline on when this PR is going to be merged? I have the same issue which this PR fixes. Thanks. |
|
I also have the same issue. May I know when this PR will be merged? Thanks. |
|
I’ve never experienced this issue. I feel like you put GoogleService-Info into a wrong location. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was getting this error before this pull-request:
People from
cordova-plugin-firebasewere having the same problem, which I've got the fix from here: arnesson/cordova-plugin-firebase#866 (comment)This fix has been merged on
cordova-plugin-firebaseproject, and can be observed here: https://github.com/arnesson/cordova-plugin-firebase/blob/db3b661fc7fe23694794c9d4e8f9f10c8eb7d649/src/ios/AppDelegate%2BFirebasePlugin.m#L51-L61